-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Disconnect db service on shutdown #327
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d2c7e41
Disconnect db service on shutdown
BobdenOs 0194be9
Merge branch 'main' into cap/14736
patricebender 04e3e00
Merge branch 'main' of https://github.com/cap-js/cds-dbs into cap/14736
BobdenOs 9a370c5
Disconnect all tenants if not specified
BobdenOs d88fe2e
Merge branch 'cap/14736' of https://github.com/cap-js/cds-dbs into ca…
BobdenOs 25d29a4
Re arrange disconnect
BobdenOs f3a4dff
Hide _factory to simplify disconnect
BobdenOs 1a4daf5
Merge branch 'main' into cap/14736
BobdenOs 911b4f6
Merge branch 'main' into cap/14736
johannes-vogel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to implement something that disconnects all tenant pools in multitenancy mode. Something like
disconnect('*')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disconnect(undefined)
should match all tenants. Will update thedisconnect
function to just go over all pools.