fix: Support multi byte characters #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
requested review from
danjoa,
johannes-vogel,
stewsk and
patricebender
as code owners
oklemenz2
approved these changes
May 13, 2024
patricebender
approved these changes
May 13, 2024
There was a problem hiding this comment.
I would omit the scope hana.
Since the PR title will be put into the @cap-js/hana changelog, it is not necessary to mention the database in the commit message. In 34aa381 I had to manually cleanup the changelog bc of this
BobdenOs
changed the title
BobdenOs
changed the title
Merged
oklemenz2
reviewed
May 14, 2024
| @@ -31,6 +31,9 @@ module.exports = [ | |||
| { | |||
| char: 'A', | |||
| }, | |||
| { | |||
| char: '대', // Ensure multi byte utf-8 characters also fit into a single character column | |||
There was a problem hiding this comment.
Are we sure, that the character that is not utf-8 converted is still the same, when read from database?
Maybe a test can be added, that INSERTed value is the same then the afterwards selected value...
oklemenz2
reviewed
May 14, 2024
| @@ -1028,6 +1028,7 @@ class HANAService extends SQLService { | |||
| Int64: () => `BIGINT`, | |||
| UUID: () => `NVARCHAR(36)`, | |||
| Boolean: () => `NVARCHAR(5)`, | |||
| String: e => `NVARCHAR(${(e.length || 5000) * 4})`, | |||
There was a problem hiding this comment.
Is this enough for all use-cases? What is the max character that can occur...
johannes-vogel
pushed a commit
that referenced
this pull request
May 17, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.9.1</summary> ## [1.9.1](db-service-v1.9.0...db-service-v1.9.1) (2024-05-16) ### Fixed * dont mistake non-key access with foreign key ([#642](#642)) ([2cd2349](2cd2349)) </details> <details><summary>sqlite: 1.7.1</summary> ## [1.7.1](sqlite-v1.7.0...sqlite-v1.7.1) (2024-05-16) ### Fixed * **deps:** update dependency better-sqlite3 to v10 ([#636](#636)) ([0cc60e7](0cc60e7)) </details> <details><summary>hana: 0.4.0</summary> ## [0.4.0](hana-v0.3.0...hana-v0.4.0) (2024-05-16) ### Added * Allow hex engine to be used ([#641](#641)) ([bca0c01](bca0c01)) ### Fixed * Improve comparator check for combined and nested expressions ([#632](#632)) ([8e1cb4b](8e1cb4b)) * Support multi byte characters ([#639](#639)) ([4cfa77f](4cfa77f)) ### Changed * `@sap/hana-client` optional peer dependency ([#631](#631)) ([89d7149](89d7149)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Jan 28, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.