deps: @sap/hana-client optional peer dependency
#631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swaldmann
changed the title
@sap/hana-client optional peer dependency@sap/hana-client optional peer dependency
swaldmann
requested review from
danjoa,
johannes-vogel,
stewsk,
BobdenOs and
patricebender
as code owners
|
The npm documentation is very un clear about its behavior in relation to peer dependencies. It states that it gives warnings when peer dependencies are missing. Which can be disabled by making the peer dependencies optional, but it doesn't mention installing peer dependencies. https://docs.npmjs.com/cli/v7/configuring-npm/package-json#optionaldependencies |
|
It says that in the section about
|
patricebender
approved these changes
May 13, 2024
Merged
johannes-vogel
pushed a commit
that referenced
this pull request
May 17, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.9.1</summary> ## [1.9.1](db-service-v1.9.0...db-service-v1.9.1) (2024-05-16) ### Fixed * dont mistake non-key access with foreign key ([#642](#642)) ([2cd2349](2cd2349)) </details> <details><summary>sqlite: 1.7.1</summary> ## [1.7.1](sqlite-v1.7.0...sqlite-v1.7.1) (2024-05-16) ### Fixed * **deps:** update dependency better-sqlite3 to v10 ([#636](#636)) ([0cc60e7](0cc60e7)) </details> <details><summary>hana: 0.4.0</summary> ## [0.4.0](hana-v0.3.0...hana-v0.4.0) (2024-05-16) ### Added * Allow hex engine to be used ([#641](#641)) ([bca0c01](bca0c01)) ### Fixed * Improve comparator check for combined and nested expressions ([#632](#632)) ([8e1cb4b](8e1cb4b)) * Support multi byte characters ([#639](#639)) ([4cfa77f](4cfa77f)) ### Changed * `@sap/hana-client` optional peer dependency ([#631](#631)) ([89d7149](89d7149)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Jan 28, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently noticing the huge package is still coming in
@sap/cds-dkwith@sap/hdi-deployversion 5 because@cap-js/hanadefines it as a non-optional peer dependency.