fix: dont use virtual key for UPDATE … where (<key>) in <subquery>

[patricebender]

For a draft enabled model:

namespace my;

entity Books {
  key ID : Integer;
  title  : String;
  stock  : Integer;
  author : Association to Authors;
}

entity Authors {
  key ID : Integer;
  name   : String;
  alive  : Boolean;
}

service CatalogService {
    @odata.draft.enabled
    @readonly entity Books as projection on my.Books;

    @readonly entity Authors as projection on my.Authors;
}

my.Books will have a field:

        "IsActiveEntity": {
          "type": "cds.Boolean",
          "key": true,
          "default": {
            "val": true
          },
          "@UI.Hidden": true
        },

which is marked as virtual by the lean draft implementation. This virtual key must not be part of the primary key matching which is done for a path expression in a UPDATE.where:

cds-dbs/db-service/test/cqn4sql/UPDATE.test.js

Lines 73 to 97 in 982b8b7

	it('Update with path expressions in where is handled', () => {
	const { UPDATE } = cds.ql
	let u = UPDATE.entity({ ref: ['bookshop.Books'] }).where(
	`author.name LIKE '%Bron%' or ( author.name LIKE '%King' and title = 'The Dark Tower') and stock >= 15`,
	)
	let expected = UPDATE.entity({ ref: ['bookshop.Books'] })
	expected.UPDATE.where = [
	{ list: [{ ref: ['Books2', 'ID'] }] },
	'in',
	CQL`
	(SELECT Books.ID from bookshop.Books as Books
	left join bookshop.Authors as author on author.ID = Books.author_ID
	where author.name LIKE '%Bron%' or ( author.name LIKE '%King' and Books.title = 'The Dark Tower') and Books.stock >= 15
	)
	`,
	]
	expected.UPDATE.entity = {
	as: 'Books2',
	ref: ['bookshop.Books'],
	}
	let res = cqn4sql(u, model)
	expect(JSON.parse(JSON.stringify(res))).to.deep.equal(JSON.parse(JSON.stringify(expected)))
	})

TODO:

• test this

[patricebender]

also check if UPDATEs on tables w/o primary keys cause issues

[David-Kunz]

lgtm 🎸