feat: Add quoted mode support #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
requested review from
danjoa,
johannes-vogel,
stewsk,
patricebender and
sjvans
as code owners
patricebender
approved these changes
Jul 26, 2024
danjoa
reviewed
Jul 29, 2024
db-service/lib/cqn2sql.js
Outdated
| @@ -34,6 +34,12 @@ class CQN2SQLRenderer { | |||
| this.class = new.target // for IntelliSense | |||
| this.class._init() // is a noop for subsequent calls | |||
| this.model = srv?.model | |||
|
|
|||
| // Overwrite smart quoting | |||
| if (cds.env.cdsc.sqlMapping === 'quoted') { | |||
There was a problem hiding this comment.
Use official setting cds.env.sql.names instead
|
Hi! let me please just share the importance of such a feature. In our app we used quoted on purposes - because we wanted our artifacts to be created using namespace patterns as we used to have in Hana XSC. So now because of this we cannot use @cap-js/hana in our production app without significant refactoring. I'm afraid creating synonyms will not be enough. Therefore - we stay now with CAP native hana driver unless this mode is supported |
danjoa
reviewed
Aug 26, 2024
db-service/lib/cqn2sql.js
Outdated
| @@ -336,7 +342,9 @@ class CQN2SQLRenderer { | |||
| const { ref, as } = from | |||
| const _aliased = as ? s => s + ` as ${this.quote(as)}` : s => s | |||
| if (ref) { | |||
| const z = ref[0] | |||
| const { target } = SELECT.from(from) | |||
There was a problem hiding this comment.
Why do we have to create a new query to get the target?
Can't we just take it from the rendered query?
|
Hi! Is there any progress with this PR? Thanks! |
Co-authored-by: Daniel Hutzel <daniel.hutzel@sap.com>
johannes-vogel
approved these changes
Oct 1, 2024
Merged
johannes-vogel
pushed a commit
that referenced
this pull request
Oct 1, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.13.0</summary> ## [1.13.0](db-service-v1.12.1...db-service-v1.13.0) (2024-10-01) ### Added * Add quoted mode support ([#681](#681)) ([43c7a6c](43c7a6c)) ### Fixed * **deep-queries:** properly return insert result ([#803](#803)) ([8d800e2](8d800e2)) * dont use virtual key for `UPDATE … where (<key>) in <subquery>` ([#800](#800)) ([d25af70](d25af70)) * reject all path expressions w/o foreign keys ([#806](#806)) ([cd271a8](cd271a8)) </details> <details><summary>hana: 1.3.0</summary> ## [1.3.0](hana-v1.2.0...hana-v1.3.0) (2024-10-01) ### Added * Add quoted mode support ([#681](#681)) ([43c7a6c](43c7a6c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.