Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add action to enforce conventional commit messages #281

Merged
merged 6 commits into from
Oct 26, 2023

Conversation

patricebender
Copy link
Member

@patricebender patricebender commented Oct 12, 2023

adding new workflow: https://github.com/marketplace/actions/semantic-pull-request


adhering to the conventional commits format is vital to make our automatic release process with release please work.

Why Use Conventional Commits

  • Automatically generating CHANGELOGs.
  • Automatically determining a semantic version bump (based on the types of commits landed).
  • Communicating the nature of changes to teammates, the public, and other stakeholders.
  • Triggering build and publish processes.
  • Making it easier for people to contribute to our projects, by allowing them to explore a more structured commit history.

I will make this action a mandatory one. To follow the conventional commit format you only have to begin your commit message with:

<type>[optional scope]: <description>

[optional body]

[optional footer(s)]

where <type> is one of:

['feat', 'fix', 'docs', 'style', 'refactor', 'perf', 'test', 'build', 'ci', 'chore', 'revert', 'wip', 'perf']
  1. fix: a commit of the type fix patches a bug in your codebase (this correlates with PATCH in Semantic Versioning).
  2. feat: a commit of the type feat introduces a new feature to the codebase (this correlates with MINOR in Semantic Versioning).
  3. BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type.

It is also possible to have multiple fixes and features in one commit message. Please consult the conventional commits doc

adhering to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) format is vital to make our automatic release process with [release please](https://www.npmjs.com/package/release-please/v/11.14.2) work.

- Automatically generating CHANGELOGs.
- Automatically determining a semantic version bump (based on the types of commits landed).
- Communicating the nature of changes to teammates, the public, and other stakeholders.
- Triggering build and publish processes.
- Making it easier for people to contribute to our projects, by allowing them to explore a more structured commit history.

I will make this action a mandatory one. To follow the conventional commit
format you only have to begin your commit message with:

```md
<type>[optional scope]: <description>

[optional body]

[optional footer(s)]
```

where `<type>` is one of:

```js
[
    "feat",
    "fix",
    "docs",
    "style",
    "refactor",
    "test",
    "build",
    "perf",
    "ci",
    "chore",
    "revert",
    "merge",
    "wip",
]
```

1. fix: a commit of the type fix patches a bug in your codebase (this correlates with PATCH in Semantic Versioning).
2. feat: a commit of the type feat introduces a new feature to the codebase (this correlates with MINOR in Semantic Versioning).
3. BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type.

It is also possible to have multiple fixes and features in one commit message.
Please consult the [conventional commits doc](https://www.conventionalcommits.org/en/v1.0.0/)
@patricebender patricebender enabled auto-merge (squash) October 12, 2023 09:25
@patricebender patricebender changed the title ci: add action to check for conventional commit messages ci: add action to enforce conventional commit messages Oct 13, 2023
patricebender added a commit that referenced this pull request Oct 20, 2023
Add all types which are acceptable for our commits according to #281
Copy link
Contributor

@johannes-vogel johannes-vogel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm as a starting point

@patricebender patricebender merged commit 9c9be9e into main Oct 26, 2023
@patricebender patricebender deleted the conventional-commits branch October 26, 2023 11:12
johannes-vogel pushed a commit that referenced this pull request Oct 31, 2023
adhering to the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) format is vital to make our automatic release process with [release please](https://www.npmjs.com/package/release-please/v/11.14.2) work.

- Automatically generating CHANGELOGs.
- Automatically determining a semantic version bump (based on the types of commits landed).
- Communicating the nature of changes to teammates, the public, and other stakeholders.
- Triggering build and publish processes.
- Making it easier for people to contribute to our projects, by allowing them to explore a more structured commit history.

I will make this action a mandatory one. To follow the conventional commit
format you only have to begin your commit message with:

```md
<type>[optional scope]: <description>

[optional body]

[optional footer(s)]
```

where `<type>` is one of:

```js
[
    "feat",
    "fix",
    "docs",
    "style",
    "refactor",
    "test",
    "build",
    "perf",
    "ci",
    "chore",
    "revert",
    "merge",
    "wip",
]
```

1. fix: a commit of the type fix patches a bug in your codebase (this correlates with PATCH in Semantic Versioning).
2. feat: a commit of the type feat introduces a new feature to the codebase (this correlates with MINOR in Semantic Versioning).
3. BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in Semantic Versioning). A BREAKING CHANGE can be part of commits of any type.

It is also possible to have multiple fixes and features in one commit message.
Please consult the [conventional commits doc](https://www.conventionalcommits.org/en/v1.0.0/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants