chore: update postgres docker to 16 #351
Conversation
SamuelBrucksch
changed the title
SamuelBrucksch
changed the title
SamuelBrucksch
force-pushed
the
fix-postgres-16
branch
from
097a7f3 to
2613e89
Compare
SamuelBrucksch
requested review from
BobdenOs,
patricebender,
gregorwolf,
sebastianesch,
vobu,
danjoa,
johannes-vogel and
stewsk
as code owners
| @@ -3,7 +3,7 @@ version: '3.1' | |||
|
|
|||
| services: | |||
| db: | |||
| image: postgres:15-alpine | |||
| image: postgres:16-alpine | |||
There was a problem hiding this comment.
| image: postgres:16-alpine | |
| image: postgres:alpine |
There was a problem hiding this comment.
As you can see in this PR it is not always compatible to take the latest version. So please keep the exact version in the PRs. To keep the builds reproducible.
There was a problem hiding this comment.
Additionally in production they latest version is still 13. So there is no rush to test using the latest and greatest version.
There was a problem hiding this comment.
Also fine for me.
I ask myself whether we should use the "latest" version on BTP instead?
There was a problem hiding this comment.
I do think that the productive Postgres version should be tested. Whether that is in additional to the latest version or instead of the latest version is both fine with me. The advantage of also testing the latest version would give a timely heads up for things breaking in the future (around 2-3 years warning period).
There was a problem hiding this comment.
Based on the documentation page for Parameters for the PostgreSQL on SAP BTP, Hyperscaler Option, the latest available version is 14. So I would think the tests should run with 14, 15 and 16.
Co-authored-by: Johannes Vogel <31311694+johannes-vogel@users.noreply.github.com>
Co-authored-by: Bob den Os <108393871+BobdenOs@users.noreply.github.com>
|
I've created a BLI internally for adding the additional voter. |
Apparantly permission rules changed with postgres 16. This makes it work again, but as i'm no expert, I can't say for sure this is the right solution.