fix: wrong odata count in filter with groupby #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrap the groupby with a another SELECT statement.
larslutz96
requested review from
BobdenOs,
danjoa,
johannes-vogel and
stewsk
as code owners
BobdenOs
reviewed
Nov 22, 2023
BobdenOs
reviewed
Nov 23, 2023
|
Hi @johannes-vogel , would this fix the issue with the Analytical List Page in SFlight? |
|
@stewsk Yes, that's the PR for it. |
BobdenOs
approved these changes
Nov 29, 2023
|
I verified this also locally with sflight and works as expected 👍 |
johannes-vogel
approved these changes
Nov 29, 2023
johannes-vogel
deleted the
fix-wrong-odata-count-in-filter-with-groupby
branch
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encase the groupby within an additional SELECT statement to ensure accurate row counting.