fix(cqn4sql): be robust against $self.<element> references
#471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a `ref` of length > 1, has `ref[0] === 'self'`, the `$self` can just be ignored. `$self` comparisons have only special semantics if compared to an association. With this change, we become more robust in that regard and do not prepend wrong table aliases for the case `$self.<assoc>.<element>` - in that case, we must ensure that the alias of the association is used and not the alias of the entity.
patricebender
requested review from
danjoa,
johannes-vogel and
stewsk
as code owners
patricebender
commented
Feb 19, 2024
db-service/lib/cqn4sql.js
Outdated
Comment on lines
1817
to
1822
| if (lhs.ref[0] === '$self') { // $self in ref of length > 1 | ||
| // if $self is followed by association, the alias of the association must be used | ||
| if (lhs.$refLinks[1].definition.isAssociation) result[i].ref.splice(0, 1) | ||
| // otherwise $self points to the entity itself | ||
| else result[i].ref.splice(0, 1, targetSideRefLink.alias) | ||
| } else if (lhs.ref.length > 1) { |
There was a problem hiding this comment.
relevant changes, other stuff is formatting
stewsk
approved these changes
Feb 20, 2024
Merged
patricebender
added a commit
that referenced
this pull request
Feb 21, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.6.3</summary> ## [1.6.3](db-service-v1.6.2...db-service-v1.6.3) (2024-02-20) ### Fixed * **`cqn4sql`:** be robust against `$self.<element>` references ([#471](#471)) ([2921b0e](2921b0e)) * **cds.infer:** Always use srv.model ([#451](#451)) ([41cf4a2](41cf4a2)) * Throw 'new Error' instead of string on $search with multiple words ([#472](#472)) ([51be94d](51be94d)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Patrice Bender <patrice.bender@sap.com>
Merged
This was referenced Jan 28, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a
refof length > 1, hasref[0] === 'self', the$selfcan just be ignored.$selfcomparisons have only special semantics if compared to an association. With this change, we become more robust in that regard and do not prepend wrong table aliases for the case$self.<assoc>.<element>- in that case, we must ensure that the alias of the association is used and not the alias of the entity. Follow up #468