test: post processing with custom join #480
Conversation
patricebender
requested review from
danjoa,
johannes-vogel,
stewsk and
BobdenOs
as code owners
patricebender
force-pushed
the
join-test
branch
from
2af380e to
b479340
Compare
test/bookshop/db/schema.cds
Outdated
| @@ -21,6 +21,7 @@ entity Authors : managed { | |||
| dateOfDeath : Date; | |||
There was a problem hiding this comment.
Date type has an output converter.
If you want to check every type. It is possible to use the compliance model, but you will need to define a non sense join condition.
There was a problem hiding this comment.
I'd propose to simply use validate the date output instead.
There was a problem hiding this comment.
forget my comment, the date type is already sanitized on insert.
There was a problem hiding this comment.
I've added a where clause for the join to identify the right entry
There was a problem hiding this comment.
is it okay for you guys to just check the boolean?
There was a problem hiding this comment.
cds.Date gets translated into an cds.Timestamp format for storage and is then converted back into an cds.Date format using the output converter. Additionally cds.Boolean doesn't always have an output converter. While cds.Date always has one for all current database services.
I can take over the PR if that is prefered @patricebender
There was a problem hiding this comment.
for cds.date we have input converters that ensure YY-MM-DD format:
cds-dbs/sqlite/lib/SQLiteService.js
Line 180 in 2580c24
There was a problem hiding this comment.
I can take over the PR if that is prefered @patricebender
fine by me. :)
the reason why we came up with this was that we wanted to check whether there is a better place for the "hack" implemented in #469
No description provided.