Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore streaming properties #570

Closed
wants to merge 2 commits into from
Closed

fix: ignore streaming properties #570

wants to merge 2 commits into from

Conversation

SamuelBrucksch
Copy link
Contributor

No description provided.

@BobdenOs BobdenOs requested review from etimr and vkozyura April 10, 2024 12:14
sjvans
sjvans requested changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@sjvans sjvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

element.type === 'cds.LargeBinary' should be the only check

@SamuelBrucksch SamuelBrucksch deleted the ignore-streaming-properties branch April 10, 2024 12:31
patricebender added a commit that referenced this pull request Apr 10, 2024
@patricebender
fix: exclude cds.LargeBinary from wildcard expansion
c35c539 
before this change, only the `MediaType` annotation was checked,
but we should rather check the elements type as pointed out
in [this comment](#570 (review))
@patricebender patricebender mentioned this pull request Apr 10, 2024
Merged
patricebender added a commit that referenced this pull request Apr 11, 2024
@patricebender
fix: exclude cds.LargeBinary from wildcard expansion (#577)
6661d63 
before this change, only the `MediaType` annotation was checked, but we
should rather check the elements type as pointed out in [this
comment](#570 (review))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjvans sjvans sjvans requested changes

@BobdenOs BobdenOs BobdenOs approved these changes

@danjoa danjoa Awaiting requested review from danjoa danjoa is a code owner

@johannes-vogel johannes-vogel Awaiting requested review from johannes-vogel johannes-vogel is a code owner

@stewsk stewsk Awaiting requested review from stewsk stewsk is a code owner

@patricebender patricebender Awaiting requested review from patricebender patricebender is a code owner

@etimr etimr Awaiting requested review from etimr

@vkozyura vkozyura Awaiting requested review from vkozyura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamuelBrucksch @sjvans @BobdenOs