fix(hana): Apply time zones when inserting timestamps and datetimes #606
+112
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
requested review from
danjoa,
johannes-vogel,
stewsk and
patricebender
as code owners
|
cds.extend (compile.to.hdbtable) .with (class { |
hana/lib/drivers/base.js
Outdated
|
|
||
| // Consider that '-' is only allowed as timezone after ':' or 'T' | ||
| await prom(this._native, 'exec')(` | ||
| CREATE OR REPLACE FUNCTION ISO(RAW NVARCHAR(36)) |
There was a problem hiding this comment.
I have moved the function to the plugin now for hdi artifacts. I think we should enrich the compile.to.sql commands for our tests that are used under the hood. the function creation should rather be part of deployment.
I was also wondering whether we should add a prefix to ensure uniqueness also for the future.
Co-authored-by: Bob den Os <bob.den.os@sap.com>
BobdenOs
requested review from
gregorwolf,
sebastianesch and
vobu
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.