Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wrap client if @dynatrace/oneagent-sdk is present #777

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

sjvans
Copy link
Contributor

@sjvans sjvans commented Aug 12, 2024

todos:

  • remove unused code (if streaming extension is not needed)
  • document on capire?

it works (the yellow span):
Screenshot 2024-08-12 at 21 56 28

@sjvans sjvans marked this pull request as ready for review August 13, 2024 13:07
@johannes-vogel johannes-vogel changed the title feat(hana): wrap client if @dynatrace/oneagent-sdk is present feat: wrap client if @dynatrace/oneagent-sdk is present Aug 19, 2024
@@ -0,0 +1,91 @@
// COPIED AS IS (excluding unused code) FROM @sap/cds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a long term or temporary solution ? As native support from @sap/hana-client was requested.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sebastian mentioned that Daniel agreed to implement that on our side as observability colleagues claimed the feature degradation to the legacy hana service.

I'm afraid that this will stay on us for a longer time.

@johannes-vogel johannes-vogel added the next release pr to be checked for next release label Aug 28, 2024
@johannes-vogel johannes-vogel merged commit 147b88e into main Sep 2, 2024
4 checks passed
@johannes-vogel johannes-vogel deleted the dynatrace branch September 2, 2024 11:34
@cap-bots cap-bots mentioned this pull request Sep 2, 2024
johannes-vogel pushed a commit that referenced this pull request Sep 4, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>db-service: 1.12.1</summary>

##
[1.12.1](db-service-v1.12.0...db-service-v1.12.1)
(2024-09-03)


### Fixed

* deep `groupby` expand queries
([#768](#768))
([5423cf3](5423cf3))
* **deep:** prevent false unique constraint errors and combine delete
queries ([#781](#781))
([01de95f](01de95f))
* **logging:** from changes in @sap/cds
([#791](#791))
([1e8bf06](1e8bf06))
* prepend aliases to refs within function args in on conditions
([#795](#795))
([9b34314](9b34314)),
closes [#779](#779)
* prevent $search queries from throwing
([#772](#772))
([cdf4d37](cdf4d37))
</details>

<details><summary>hana: 1.2.0</summary>

##
[1.2.0](hana-v1.1.1...hana-v1.2.0)
(2024-09-03)


### Added

* wrap client if @dynatrace/oneagent-sdk is present
([#777](#777))
([147b88e](147b88e))


### Fixed

* Add `{list:[{val}]}` json function support
([#784](#784))
([ce5f856](ce5f856))
* Allow applications to configure `acquireTimeoutMillis`
([#796](#796))
([abac818](abac818))
* deep `groupby` expand queries
([#768](#768))
([5423cf3](5423cf3))
* Enforce `LargeStrings` to be `Strings` for `sql_simple_queries=1`
([#774](#774))
([c38a9e6](c38a9e6))
* wrong falsy checks for vals in list optimization
([#797](#797))
([e818da8](e818da8))


### Changed

* requires @sap/cds &gt;= 8.2
([#789](#789))
([3bbde18](3bbde18))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release pr to be checked for next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants