Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: import of compareJSON #814

Merged
merged 1 commit into from
Sep 20, 2024
Merged

refactor: import of compareJSON #814

merged 1 commit into from
Sep 20, 2024

Conversation

fliellerjulian
Copy link
Contributor

@fliellerjulian fliellerjulian commented Sep 20, 2024

Closes: [cdsnode #2157]

Simplified the import of compareJSON by removing the old path

@fliellerjulian fliellerjulian changed the title Refactor: import of compareJSON refactor: import of compareJSON Sep 20, 2024
Copy link
Member

@patricebender patricebender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@fliellerjulian fliellerjulian merged commit 3535a4e into main Sep 20, 2024
8 checks passed
@fliellerjulian fliellerjulian deleted the compareJson-import branch September 20, 2024 09:15
@johannes-vogel
Copy link
Contributor

I think we should increase the minimum cds version in addition

johannes-vogel added a commit that referenced this pull request Oct 1, 2024
johannes-vogel added a commit that referenced this pull request Oct 1, 2024
This reverts commit 3535a4e.
the next hotfix should still be consumable in cds7 due to customer
ticket.
johannes-vogel pushed a commit that referenced this pull request Oct 1, 2024
Closes: [cdsnode #2157]

Simplified the import of compareJSON by removing the old path

Co-authored-by: Julian Flieller <julian.flieller@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants