fix: add missing function mappings #945
Conversation
patricebender
requested review from
BobdenOs,
gregorwolf,
sebastianesch,
vobu,
danjoa,
johannes-vogel,
stewsk and
sjvans
as code owners
|
Tests ? |
patricebender
changed the title
| ( | ||
| ( |
There was a problem hiding this comment.
didnt work before, because we already have seconds from the EXTRACT(EPOCH) step, so multiplying by 86400 again drastically inflates the result.
There was a problem hiding this comment.
Why no just move the multiplication and keep the EXTRACT and replace syntax ? As the new split_part syntax repeats the same string functions over and over again.
👍 |
| // By splitting the DT and calculating the seconds of the time separate from the day | ||
| // it possible to determine the full amount of seconds by adding them together as fractionals and multiplying | ||
| // the number of seconds in a day | ||
| // As sqlite is most accurate with juliandays it is better to do then then using actual second function | ||
| // while the odata specification states that the seconds has to be fractional which only julianday allows | ||
| /** | ||
| * Generates SQL statement that produces an OData compliant duration string like: P12DT23H59M59.999999999999S | ||
| * Generates SQL statement that produces a number for a OData compliant duration string like: P12DT23H59M59.999999999999S |
There was a problem hiding this comment.
Not sure what happened with this sentence, but it should be something more like:
| * Generates SQL statement that produces a number for a OData compliant duration string like: P12DT23H59M59.999999999999S | |
| * Generates a SQL statement that processes an OData compliant duration string: P12DT23H59M59.999999999999S |
There was a problem hiding this comment.
that makes more sense, however why not state what the function returns as well?
| ( | ||
| ( |
There was a problem hiding this comment.
Why no just move the multiplication and keep the EXTRACT and replace syntax ? As the new split_part syntax repeats the same string functions over and over again.
No description provided.