fix: Force sql_simple_queries to quote in outer select
#954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobdenOs
requested review from
danjoa,
johannes-vogel,
stewsk,
patricebender,
sjvans and
David-Kunz
as code owners
johannes-vogel
approved these changes
Dec 18, 2024
soccermax
reviewed
Dec 18, 2024
hana/lib/HANAService.js
Outdated
| @@ -426,7 +426,7 @@ class HANAService extends SQLService { | |||
| q.as = q.SELECT.from.as | |||
| } | |||
|
|
|||
| if (rowNumberRequired || q.SELECT.columns.length !== aliasedOutputColumns.length) { | |||
| if (cds.env.features.sql_simple_queries || rowNumberRequired || q.SELECT.columns.length !== aliasedOutputColumns.length) { | |||
There was a problem hiding this comment.
wouldn't it be enough to only do this for orderBy or having clauses? Or are there more cases where the nesting is really needed?
johannes-vogel
deleted the
fix/sql_simple_queries-orderby-result-column
branch
Merged
johannes-vogel
pushed a commit
that referenced
this pull request
Dec 18, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.16.2</summary> ## [1.16.2](db-service-v1.16.1...db-service-v1.16.2) (2024-12-18) ### Fixed * do not override .toJSON of buffers ([#949](#949)) ([ed52f72](ed52f72)) </details> <details><summary>hana: 1.5.2</summary> ## [1.5.2](hana-v1.5.1...hana-v1.5.2) (2024-12-18) ### Fixed * Force `sql_simple_queries` to quote in outer select ([#954](#954)) ([2071dc8](2071dc8)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.