Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for @UI.HeaderInfo.TypeName #124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

schiwekM
Copy link

@schiwekM schiwekM commented Oct 7, 2024

Hi colleagues,

for the object type column the label of the entity is being used. However it is not common that entities are annoyed with a label. Instead they usually have the @UI.HeaderInfo annotation annotated as it dictates app, object page and table names in Fiori elements. Thus change tracking should also consider this annotation as a fallback.

@UI.HeaderInfo.TypeNamePlural is also an option if desired. Moreover @UI.HeaderInfo.Title defines the object page identifier for a rotation and it might make sense to consider this for a nicer Object Key (or consider @Common.SemanticKey).

BR,
Marten

@Sv7enNowitzki
Copy link
Collaborator

Hi @schiwekM ,
Thank you for your PR, we will merge it into main branch.

Best Regards,
Wenjun

@Sv7enNowitzki Sv7enNowitzki self-requested a review October 16, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants