Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flattened readme #32

Merged
merged 20 commits into from
Oct 26, 2023
Merged

Flattened readme #32

merged 20 commits into from
Oct 26, 2023

Conversation

danjoa
Copy link
Contributor

@danjoa danjoa commented Oct 19, 2023

No description provided.

@danjoa danjoa requested a review from mnkiefer October 19, 2023 20:47
Copy link
Contributor

@mnkiefer mnkiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Daniel, looks great! 👍 I like that you now have the calesi alternative if you want to skip the step-by-step and jump right in.

One thing though, I believe we still need the header ##About this project to ensure OSS compliance.

@sjvans: Could you please comment on the structure that was requested for the README which you also adhered to in @cap-js/audit-logging?

@mnkiefer mnkiefer requested a review from sjvans October 20, 2023 06:21
@sjvans
Copy link
Contributor

sjvans commented Oct 20, 2023

Hi Daniel, looks great! 👍 I like that you now have the calesi alternative if you want to skip the step-by-step and jump right in.

One thing though, I believe we still need the header ##About this project to ensure OSS compliance.

@sjvans: Could you please comment on the structure that was requested for the README which you also adhered to in @cap-js/audit-logging?

The README.md file should be broken down into the following sections.
- Mandatory Sections
  - Description
  - Requirements
  - Contributing
  - Code of Conduct
  - Licensing
- Optional Sections
  - Download & Installation
  - Configuration
  - Limitations
  - Known Issues
  - How to Obtain Support
  - To-Do (Upcoming changes)

i'll send you some internal links via chat ;)

Copy link
Contributor

@sjvans sjvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm afraid we'll need to retain .reuse and LICENSES

README.md Show resolved Hide resolved
@sjvans sjvans mentioned this pull request Oct 20, 2023
@mnkiefer
Copy link
Contributor

Hi Daniel, looks great! 👍 I like that you now have the calesi alternative if you want to skip the step-by-step and jump right in.
One thing though, I believe we still need the header ##About this project to ensure OSS compliance.
@sjvans: Could you please comment on the structure that was requested for the README which you also adhered to in @cap-js/audit-logging?

The README.md file should be broken down into the following sections.
- Mandatory Sections
  - Description
  - Requirements
  - Contributing
  - Code of Conduct
  - Licensing
- Optional Sections
  - Download & Installation
  - Configuration
  - Limitations
  - Known Issues
  - How to Obtain Support
  - To-Do (Upcoming changes)

i'll send you some internal links via chat ;)

@sjvans: Thanks for the links! 👍 According to the repo linting tool, we should still have a section called Requirements, right?

Warning

[rl-readme_file-2] README is incomplete. Please check the following sections: Requirements
Warning

@sjvans
Copy link
Contributor

sjvans commented Oct 20, 2023

@sjvans: Thanks for the links! 👍 According to the repo linting tool, we should still have a section called Requirements, right?

Warning [rl-readme_file-2] README is incomplete. Please check the following sections: Requirements Warning

not a must. however, the tool only lints main, so you'll need to merge this first to see if there are new violations.

@danjoa
Copy link
Contributor Author

danjoa commented Oct 20, 2023

Let's discuss that in our next sync.
Priority is conciseness and comprehensibility, not formalism

@nkaputnik
Copy link
Contributor

We should also add a disclaimer on the top that this is Early Adopters and production use is on your own risk.
Nils Hirsekorn already raised a performance isse and "expects" a resolution. Clearly, have diverging expectations from an open source project...

@mnkiefer
Copy link
Contributor

We should also add a disclaimer on the top that this is Early Adopters and production use is on your own risk. Nils Hirsekorn already raised a performance isse and "expects" a resolution. Clearly, have diverging expectations from an open source project...

We've addressed this here 👍

@mnkiefer mnkiefer requested a review from sjvans October 25, 2023 18:35
package.json Show resolved Hide resolved
README.md Show resolved Hide resolved
@sjvans sjvans self-requested a review October 25, 2023 18:40
Copy link
Contributor

@sjvans sjvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@danjoa danjoa merged commit 2642a4d into main Oct 26, 2023
3 checks passed
@danjoa danjoa deleted the flattened-readme branch October 26, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants