behavior to test not reproducible with jest

cap-js · Oct 9, 2024 · 061763b · 061763b
1 parent 874324b
commit 061763b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/exporter/ConsoleSpanExporter.js b/lib/exporter/ConsoleSpanExporter.js
@@ -100,9 +100,8 @@ class ConsoleSpanExporter /* implements SpanExporter */ {
  */
  _sendSpans(spans, done) {
  for (const span of spans) {
- // const w3c_parent_id = cds.context.http?.req.headers.traceparent?.split('-')[2]
- // if (!span.parentSpanId || span.parentSpanId === w3c_parent_id || span.name === 'cds.spawn') {
- if (!span.parentSpanId || span.name === 'cds.spawn') {
+ const w3c_parent_id = cds.context.http?.req.headers.traceparent?.split('-')[2]
+ if (!span.parentSpanId || span.parentSpanId === w3c_parent_id || span.name === 'cds.spawn') {
  let toLog = 'elapsed times:'
  toLog += _span2line(span)
  const children = this._temporaryStorage.get(span.spanContext().traceId)

diff --git a/test/tracing.test.js b/test/tracing.test.js
@@ -17,7 +17,8 @@ describe('tracing', () => {
  expect(log.output).to.match(/\s+\d+\.\d+ → \s*\d+\.\d+ = \s*\d+\.\d+ ms \s* AdminService - READ AdminService.Books/)
  })
 
- test('GET with traceparent is traced', async () => {
+ // REVISIT: jest breaks otel's patching of incoming request handling -> no span for 'GET' -> behavior to test not reproducible
+ xtest('GET with traceparent is traced', async () => {
  const config = { ...admin, headers: { traceparent: '00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01' } }
  const { status } = await GET('/odata/v4/admin/Books', config)
  expect(status).to.equal(200)