This repository has been archived by the owner on Oct 10, 2024. It is now read-only.
ios fix: move Optional nil check to prevent unwrapping error #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@minvernizzinextbit thank you for your PR! I will do my best to have a look at this today! Hopefully I will find time to check it out :) |
|
@minvernizzinextbit I had to copy your changes to the Thank you very much! |
|
Glad I could help! Keep up the amazing work 🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @thegnuu. First of all, thanks for your work on this super helpful plugin! I really appreciate all the effort you (and other maintainers) put into this.
I recently updated the plugin to make it work with XCode 14 and Capacitor 4 and after running my tests I found that the app was crashing after closing the BarcodeScanner instance. After looking into it I realized that a small change in the swift code would solve the issue. I'm not an expert Swift developer so I might have missed something else, but after the fix the plugin seems to work as expected. Any feedback would be really appreciated.
This small fix moves the Optional nil check inside
DispatchQueueto prevent an unwrapping error onstopScan()that crashes the app using this plugin.