Skip to content
This repository has been archived by the owner on Oct 10, 2024. It is now read-only.

android torch off, and iOS #75

Closed

Conversation

arnotixe
Copy link

@arnotixe arnotixe commented Aug 29, 2021

Fix for:

  • Turn off android torch on disableTorch()
  • Implemented on/off in iOS

tested on exactly 3 iPhones and 1 android device 😄

sorry about the iOS code repetition, I know zip about swift but found hints on https://stackoverflow.com/questions/27207278/how-to-turn-flashlight-on-and-off-in-swift/27334447 and basically copied it over twice, once for off and once for on 👍 Someone feel free to DRY the code by implement a setTorch(bool) in swift code too.

@arnotixe
Copy link
Author

I see there are now 2 PR for this feature :)
Happy with whichever being merged − seems to be a popular feature to fix…

@thegnuu
Copy link
Collaborator

thegnuu commented Feb 27, 2022

@arnotixe Thank you very much for your contribution! I will merge #78 because it will as well add the functionality to get the current state :)

@thegnuu thegnuu closed this Feb 27, 2022
@arnotixe arnotixe deleted the torchoffandios branch March 12, 2022 01:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants