fix(android): register state receivers as REGISTER_EXPORTED #663 #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @peitschie for looking into this. However I cannot reproduce the problem described in #663. Do you have a case where that crash happened? |
|
@allcontributors please add @peitschie for code and question |
|
I've put up a pull request to add @peitschie! 🎉 |
|
@pwespi huh... you are 100% correct here. I'd seen this on at least one of the registerReceivers on another plugin, and assumed it applied more widely than it actually does. There is a carved out exception for System Broadcasts when using a Context#registerReceiver call: https://developer.android.com/about/versions/14/behavior-changes-14#system-broadcasts which looks like it covers all the usages you have here. This change isn't necessary at all. Sorry for the wasted time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't got many devices to test this on currently, but this should be the code change needed here.