Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When looking for an Implementation renderer considers all TypeInstances available in the system #358

Closed
lukaszo opened this issue Jun 18, 2021 · 1 comment
Labels
area/engine Relates to Engine bug Something isn't working
Milestone

Comments

@lukaszo
Copy link
Contributor

lukaszo commented Jun 18, 2021

Description

There is a TypeInstance with AWS credentials available in the system. It's not used in any Policy and is not passed when creating an Action.

When creating a new Action, for example cap.interface.database.postgresql.install, renderer chooses an Implementation for AWS. The installation fails because there was no TypeInstance with credentials passed to the Implementation.

Expected behavior

Render should choose Helm based Implementation.

Actual behavior

Render notices that TypeInstance with AWS credentials is available and decides to use RDS Implementation.

Steps to reproduce

  1. Create TypeInstance with AWS credentials
  2. Create Action for installing a database: cap.interface.database.postgresql.install
  3. Wait for it to be Ready to run and run it.
  4. It should fail.

Proposed solution

Instead of using all available TypeInstances consider only TypeInstance passed via Policy or directly by user.
Currently TypeInstances are get here

typeInstanceValues, err := e.listCurrentTypeInstanceValues(ctx)

@pkosiec
Copy link
Member

pkosiec commented Aug 27, 2021

Fixed in #438

@pkosiec pkosiec closed this as completed Aug 27, 2021
@pkosiec pkosiec added this to the 0.5.0 milestone Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Relates to Engine bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants