-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Policy engine to support additionalTypeInstances and tidy up syntax #438
Labels
Milestone
Comments
mszostok
added
enhancement
New feature or request
breaking
Contains breaking change
area/engine
Relates to Engine
size/XXL
labels
Aug 10, 2021
This was referenced Aug 19, 2021
This was referenced Aug 19, 2021
This was referenced Aug 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
Currently, we are not able to pass additional TypeInstances in an obvious way. This task is about adjusting Policy to support more use-cases that are useful when working with Capact.
Acceptance Criteria
There are three different areas to improve. We can treat them as subtasks:
Required TypeInstances (4SP)
implementationConstraints
base on attributes and doesn't know exact alias for a given TI. What he wants to do, is to simply say prefer AWS solutions and here is AWS account that should be used.apiVersion
from PolicyListImplementationRevisionForInterface
to ignore Implementation which hasrequiredTypeInstances
but user didn't specify them in Policy. 1SP, split to: When looking for an Implementation renderer considers all TypeInstances available in the system #358Additional TypeInstances (4SP)
Additional Parameters (4SP)
Rename the
inject.additionalInput
toinject.additionalParameters
. 1SPRequire parameter name under the
additionaInput.parameters
property definition in Implementation. 3SPReason
The current implementation was good enough, but new use-cases are more sophisticated. Additionally, we want to make current syntax more readable ad usable.
The text was updated successfully, but these errors were encountered: