Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate TypeInstance input during TypeInstance creation #544

Closed
lukaszo opened this issue Oct 28, 2021 · 1 comment
Closed

Validate TypeInstance input during TypeInstance creation #544

lukaszo opened this issue Oct 28, 2021 · 1 comment
Assignees
Labels
area/cli Relates to CLI area/hub Relates to Hub enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@lukaszo
Copy link
Contributor

lukaszo commented Oct 28, 2021

Description

I've created cap.type.database.object.aws.s3.config with a typo in accesskey and TypeInstance was created without any problems.

Support:

  • CLI
  • Argo Actions TypeInstance upload - in workflow

Make sure all manifests are valid (that TypeInstance upload always succeeds as the data is valid)

Expected behavior

I've should get an error about missing accesskey key.

Actual behavior

No error was returned.

Steps to reproduce

Define TypeInstance:

typeInstances:
  - alias: aws-s3
    attributes:
      - path: cap.attribute.cloud.provider.aws
        revision: 0.1.0
    typeRef:
      path: cap.type.database.object.aws.s3.config
      revision: 0.1.0
    value:
      accessKey: aaaaa
      endpoint: https://s3.amazonaws.com

There is typo in accessKey it should be accesskey. Also, secretkey is missing.

@lukaszo lukaszo added the bug Something isn't working label Oct 28, 2021
@mszostok mszostok added the good first issue Good for newcomers label Nov 4, 2021
@mszostok mszostok added this to the 0.6.0 milestone Nov 4, 2021
@mszostok
Copy link
Member

mszostok commented Nov 4, 2021

It will be also good to validate that during the upload TypeInstance step in our workflows.

We already had such situation when uploaded TypeInstance was wrongly formatted.

@pkosiec pkosiec added area/cli Relates to CLI area/hub Relates to Hub labels Nov 16, 2021
@pkosiec pkosiec changed the title Input is not validated when creating a new TypeInstance Validate TypeInstance input during TypeInstance creation Jan 17, 2022
@pkosiec pkosiec added enhancement New feature or request and removed bug Something isn't working labels Jan 17, 2022
@mszostok mszostok modified the milestones: 0.6.0, 0.7.0 Jan 27, 2022
@mkuziemko mkuziemko self-assigned this Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Relates to CLI area/hub Relates to Hub enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants