Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes after validation of TypeInstances #56

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Fixes after validation of TypeInstances #56

merged 2 commits into from
Feb 17, 2022

Conversation

mkuziemko
Copy link
Contributor

Description

Changes proposed in this pull request:

  • change port in implementation which uses Postgres to be number (not string),
  • remote tablespace in Postgres - not used by TypeInstance,
  • in capact/validation change key to be string, not boolean as mainly that how we use it in integration tests.

Related issue(s)

@mkuziemko mkuziemko added the area/hub-manifests Relates to Hub manifests label Feb 10, 2022
@mkuziemko mkuziemko mentioned this pull request Feb 10, 2022
Merged
1 task
@pkosiec pkosiec self-assigned this Feb 14, 2022
pkosiec
pkosiec approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkuziemko mkuziemko merged commit 08244b7 into capactio:main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@tmitchell tmitchell Awaiting requested review from tmitchell tmitchell is a code owner

@mszostok mszostok Awaiting requested review from mszostok mszostok is a code owner

Assignees

@pkosiec pkosiec

Labels
area/hub-manifests Relates to Hub manifests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkuziemko @pkosiec