Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show sudo password prompt #474

Merged
merged 4 commits into from
Sep 6, 2021
Merged

Show sudo password prompt #474

merged 4 commits into from
Sep 6, 2021

Conversation

lukaszo
Copy link
Contributor

@lukaszo lukaszo commented Sep 3, 2021

Description

Changes proposed in this pull request:

  • Remove hiding sudo promt
  • Disable spinner when sudo may be required

Testing

  1. Remove gateway.capact.local entry from /etc/hosts
  2. Build CLI make build-tool-cli
  3. Run capact command without installing any components capact install --install-component=""

Related issue(s)

Closes #412

@lukaszo lukaszo marked this pull request as ready for review September 3, 2021 11:21
@lukaszo lukaszo added area/cli Relates to CLI bug Something isn't working labels Sep 3, 2021
@mszostok mszostok self-assigned this Sep 5, 2021
Copy link
Member

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 3 scenarios:

  • empty /etc/hosts
  • no certs
  • no certs + empty /etc/hosts

worked properly in all of them 👍

internal/cli/capact/os.go Outdated Show resolved Hide resolved
internal/cli/capact/os.go Outdated Show resolved Hide resolved
Comment on lines 30 to 31
cmd.Stdout = os.Stdout
cmd.Stderr = os.Stderr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to use textio.NewPrefixWriter(w, "\t") lib but with no luck and as discussed f2f we will improve "UI" later if necessary. For now it's already an improvement in UX 👍

lukaszo and others added 3 commits September 6, 2021 12:03
Co-authored-by: Mateusz Szostok <szostok.mateusz@gmail.com>
Co-authored-by: Mateusz Szostok <szostok.mateusz@gmail.com>
@lukaszo lukaszo merged commit 114aa29 into capactio:main Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Relates to CLI bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's not clear that user needs to provide a sudo password when updating /etc/hosts file
2 participants