Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump argo image version to v3.2.2 #542

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Conversation

mszostok
Copy link
Member

@mszostok mszostok commented Oct 27, 2021

Description

Changes proposed in this pull request:

We also had an old problem, if you will not set the new version in values.yaml file the upgrade will use the old version. Issue was already described here: Only the old values.yaml is used instead of merging them with new ones

@mszostok mszostok added bug Something isn't working dependencies Pull requests that update a dependency file labels Oct 27, 2021
@mszostok mszostok added this to the 0.6.0 milestone Oct 27, 2021
@pkosiec pkosiec self-assigned this Oct 27, 2021
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • There's one comment that the issue can be also encountered in 3.2.0-rc6 - maybe we should use pre-3.2.0 version? 🤔
  • If we're pretty sure the bug is fixed in 3.2.2, then there is also a bran-new 3.2.3 version from 9 hours ago, we can use it 🙂

Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After f2f discussion we'll stick with 3.2.2 because there's no changelog for 3.2.3 yet and we use the same Argo client. Hope we won't encounter such issue 🤞

@mszostok mszostok merged commit 784e898 into capactio:main Oct 27, 2021
@mszostok mszostok deleted the update-argo-ver branch October 27, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants