Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hack/eks/install.sh and add server auth mod for Argo #549

Merged
merged 3 commits into from
Nov 4, 2021
Merged

Fix hack/eks/install.sh and add server auth mod for Argo #549

merged 3 commits into from
Nov 4, 2021

Conversation

mszostok
Copy link
Member

@mszostok mszostok commented Nov 2, 2021 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fix ingress controller Helm chart path
  • Gateway Ingress was manged by public ingress controller, where the entry in Route 53 is hard-coded to the internal ELB. The reason was the lack of gateway.ingress.annotations.class=capact override during install.
  • Add missing region to aws CLI
  • Bump EKS version to be compatible with Capact. Currently, you will get such error: 
     ✗ Installing capact Helm chart
Error: All attempts fail:
#1: while installing Helm chart [capact]: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "Ingress" in version "networking.k8s.io/v1"
#2: while installing Helm chart [capact]: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "Ingress" in version "networking.k8s.io/v1"
#3: while installing Helm chart [capact]: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "Ingress" in version "networking.k8s.io/v1"
  • The Argo server used to start with auth mode of "server" by default, but since v3.0 it defaults to the "client". As a result, you need to always pass the token (first generate it via SA). I changed it back to server as we don't expose Argo publically.

@mszostok mszostok added bug Something isn't working area/documentation Related to all activities around documentation labels Nov 2, 2021
@mszostok mszostok changed the title Bump EKS version and add server auth mod for Argo Fix hack/eks/install.sh and add server auth mod for Argo Nov 3, 2021
mszostok
mszostok commented Nov 3, 2021
View reviewed changes
hack/eks/install.sh
@@ -77,7 +77,7 @@ capact::aws::install::capact() {
shout "Deploying Capact..."
capact install --environment eks \
--version "${CAPACT_VERSION}" \
--capact-overrides "global.domainName=${CAPACT_DOMAIN_NAME}" \
--capact-overrides "global.domainName=${CAPACT_DOMAIN_NAME},gateway.ingress.annotations.class=capact" \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can also move it to CLI if needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep it as it is 👍

@mszostok mszostok added this to the 0.6.0 milestone Nov 4, 2021
pkosiec
pkosiec approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

hack/eks/install.sh
@@ -77,7 +77,7 @@ capact::aws::install::capact() {
shout "Deploying Capact..."
capact install --environment eks \
--version "${CAPACT_VERSION}" \
--capact-overrides "global.domainName=${CAPACT_DOMAIN_NAME}" \
--capact-overrides "global.domainName=${CAPACT_DOMAIN_NAME},gateway.ingress.annotations.class=capact" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can keep it as it is 👍

@mszostok mszostok merged commit 943e480 into capactio:main Nov 4, 2021
@mszostok mszostok deleted the fix-eks-and-argo branch November 4, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@platten platten Awaiting requested review from platten

Assignees
No one assigned
Labels
area/documentation Related to all activities around documentation bug Something isn't working
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec