Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix releasing CLIs pipeline #586

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Conversation

mszostok
Copy link
Member

@mszostok mszostok commented Dec 17, 2021

Description

Changes proposed in this pull request:

Testing

I tested that on my fork: https://github.com/mszostok/capact/runs/4558596650?check_suite_focus=true

The problem was that the on ubuntu-latest the latest UPX has 3.95 version—in this version binaries compressed for macOS cannot be executed (upx/upx#424)

Related issue(s)

Fixes #585

@mszostok mszostok added bug Something isn't working area/cli Relates to CLI area/ci Relates to CI labels Dec 17, 2021
@pkosiec pkosiec self-assigned this Dec 17, 2021
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that it works now on my machine (Intel Macbook with macOS 12.0.1 Monterey), while the previous one didn't work (weird, probably it stopped working after my upgrade to Monterey). I built Capact CLI binary and compressed it with UPX 3.96 using our Goreleaser setup in Ubuntu Docker container.

What worries me is that multiple people in the linked issue (and another one) multiple people reported also problems with 3.96, probably in different setups (e.g. ARM-based Macs, different OS version etc.). Some people recommend using upx straight from devel.

Anyway, it definitely improves the situation on Intel-based Macs. We can merge this and bump UPX version later if a new version is released.

Please take a look on one minor comment before merge 🙂

.github/workflows/branch-build.yaml Outdated Show resolved Hide resolved
Co-authored-by: Paweł Kosiec <pawel.kosiec@gmail.com>
@mszostok mszostok merged commit 1a8ea5c into capactio:main Dec 17, 2021
@mszostok mszostok deleted the fix-cli-release branch December 17, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Relates to CI area/cli Relates to CLI bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot execute latest Capact CLI on MacOS
2 participants