Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update runc Go dependency and Jinja2 templating base image #590

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Update runc Go dependency and Jinja2 templating base image #590

merged 2 commits into from
Dec 22, 2021

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Dec 21, 2021 •
edited
Loading

Description

Changes proposed in this pull request:

  • Update runc Go dependency (resolve GHSA-v95c-p5hm-xq8f)

  • Update Jinja2 templating base image (resolve 12 vulnerability issues - see screenshot)

    Screenshot 2021-12-21 at 13 41 05

I will update the Jinja image in Hub manifests after this PR merge.

Testing

  1. Checkout this repo (e.g. using gh CLI)
  2. Run:
cd hack/images/jinja2

docker run --rm -it -v $PWD/testdata:/data ghcr.io/capactio/pr/infra/jinja2:PR-590 /data/user.tmpl /data/data1.yaml --format=yaml -o /data/render.yaml

@pkosiec pkosiec added bug Something isn't working dependencies Pull requests that update a dependency file security Pull requests that fixes security issues labels Dec 21, 2021
@pkosiec pkosiec mentioned this pull request Dec 21, 2021
Merged
@pkosiec pkosiec added the WIP Work in progress label Dec 21, 2021
@pkosiec pkosiec removed the WIP Work in progress label Dec 21, 2021
mkuziemko
mkuziemko approved these changes Dec 22, 2021
View reviewed changes
Copy link

@mkuziemko mkuziemko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@pkosiec pkosiec merged commit c8751c6 into capactio:main Dec 22, 2021
@pkosiec pkosiec deleted the fix-vulnerability branch December 22, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkuziemko mkuziemko mkuziemko approved these changes

@mszostok mszostok Awaiting requested review from mszostok mszostok is a code owner

@platten platten Awaiting requested review from platten

Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file security Pull requests that fixes security issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkosiec @mkuziemko