Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nest Interface Policy under the interface field #625

Merged
merged 3 commits into from
Feb 5, 2022

Conversation

mszostok
Copy link
Member

@mszostok mszostok commented Jan 31, 2022

Description

Changes proposed in this pull request:

  • Nest Interface Policy under the interface field
  • Use our Go client to update Policy instead of doing that on raw ConfigMap. The config map update was implemented before we had the GraphQL cli:
    func updateClusterPolicyConfigMap(stringToFind, stringToReplace string) func() {
    Currently, it doesn't make sens to use it. It's better to test our client and do that via GraphQL to simulate a real user interaction.
    • For now I decided, to leave it as Global Policy, but IMO it will be good to change it to Action Policy, so the global cluster state won't be changed during executing e2e tests.

NOTE: The easiest way to review is to select "Hide whitespaces".
Screen Shot 2022-01-31 at 14 34 05

Related issue(s)

@mszostok mszostok added breaking Contains breaking change area/engine Relates to Engine area/cli Relates to CLI labels Jan 31, 2022
@mszostok mszostok force-pushed the policy-syntax/nest-interface branch 5 times, most recently from 139e2df to f87564f Compare January 31, 2022 12:22
@mszostok mszostok added the WIP Work in progress label Jan 31, 2022
@mszostok mszostok force-pushed the policy-syntax/nest-interface branch 3 times, most recently from fbf22cc to d58b7ed Compare January 31, 2022 16:37
test/e2e/e2e_suite_test.go Outdated Show resolved Hide resolved
@mszostok mszostok removed the WIP Work in progress label Feb 3, 2022
Copy link

@mkuziemko mkuziemko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 👍 Some suggestions/questions added.

internal/k8s-engine/graphql/domain/policy/converter.go Outdated Show resolved Hide resolved
pkg/engine/k8s/policy/metadata/metadata.go Show resolved Hide resolved
test/e2e/action_test.go Show resolved Hide resolved
Copy link

@mkuziemko mkuziemko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mszostok mszostok merged commit 392c85d into capactio:main Feb 5, 2022
@mszostok mszostok deleted the policy-syntax/nest-interface branch February 5, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Relates to CLI area/engine Relates to Engine breaking Contains breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants