Fix resolving backend.context in cypher #662
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
backend.context
in cypher. Currently, the context was always taken from the user input even if thebackend
was not sent. This against our contract, in case of empty backend we should use the oldbackend.context
Update scenario:
backend
is not sent, use old settingsbackend
was sent, use newbackend.context
value (if it'snull
then persistnull
which means, zerobackend.context
property)Testing
Run neo4j:
Run storage server:
Run Local Hub:
Run test:
You can also manually test that using GraphQL playground.