Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap Helm storage backend Go app #669

Merged
merged 5 commits into from
Mar 16, 2022

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Mar 16, 2022

Description

Changes proposed in this pull request:

  • Bootstrap Helm storage backend Go app for both Release and Templating gRPC servers

Additional:

  • Add missing Go comments for macOS-only source code (to avoid lint errors on macOS)
  • Fix duplicated logger name on healthz endpoints
  • Make new Hadolint not failing on syntax comment in Dockerfile

Testing

No testing required, as the services are not yet implemented. But you can run them anyway if you want - just follow the README.md inside cmd/helm-storage-backend/ directory 🙂

You can also run some gRPC calls from Insomnia, but unfortunately the response won't be that useful - that's why I added logging to the sample GetValue method.
Screenshot 2022-03-16 at 15 56 58

Related issue(s)

#670

@pkosiec pkosiec added enhancement New feature or request area/hub Relates to Hub labels Mar 16, 2022
Copy link
Member

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Makefile Show resolved Hide resolved
cmd/helm-storage-backend/README.md Outdated Show resolved Hide resolved
@pkosiec pkosiec enabled auto-merge (squash) March 16, 2022 20:29
@pkosiec pkosiec merged commit df0a168 into capactio:main Mar 16, 2022
@pkosiec pkosiec deleted the setup-helm-storage branch March 16, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hub Relates to Hub enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants