Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Helm storage backends in Helm runner #686

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Mar 22, 2022

Description

Changes proposed in this pull request:

  • Support Helm storage backends in Helm runner

Testing

Run Helm runner according to its Readme (./cmd/helm-runner/README.md) and observe the outputs. You can edit the install-agrs.yaml or upgrade-args.yaml.

Also, you can test it end to end on: capactio/hub-manifests#64

Related issue(s)

#673

@pkosiec pkosiec added enhancement New feature or request WIP Work in progress area/hub-manifests Relates to Hub manifests labels Mar 22, 2022
@pkosiec pkosiec force-pushed the helm-runner-use-helm-backend branch 2 times, most recently from 97661ed to 88a1652 Compare March 24, 2022 14:34
@pkosiec pkosiec removed the WIP Work in progress label Mar 24, 2022
@mszostok mszostok self-assigned this Mar 24, 2022
@pkosiec pkosiec force-pushed the helm-runner-use-helm-backend branch from ed734dc to cf3c7af Compare March 24, 2022 19:01
Copy link
Member

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merge, please address my minor comments 👍

pkg/runner/helm/output.go Outdated Show resolved Hide resolved
pkg/runner/helm/types.go Outdated Show resolved Hide resolved
pkg/runner/helm/output.go Outdated Show resolved Hide resolved
@pkosiec pkosiec force-pushed the helm-runner-use-helm-backend branch from cf3c7af to f551bc8 Compare March 25, 2022 09:55
@pkosiec pkosiec force-pushed the helm-runner-use-helm-backend branch from f551bc8 to 277edfe Compare March 25, 2022 09:58
@pkosiec pkosiec merged commit a6e226e into capactio:main Mar 25, 2022
@pkosiec pkosiec deleted the helm-runner-use-helm-backend branch March 25, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hub-manifests Relates to Hub manifests enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants