Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not compress darwin arm64 binary #714

Merged
merged 3 commits into from
May 10, 2022
Merged

Do not compress darwin arm64 binary #714

merged 3 commits into from
May 10, 2022

Conversation

blazejmalecki
Copy link
Contributor

@blazejmalecki blazejmalecki commented May 6, 2022 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add new hack script responsible for compressing binary file built by goreleaser
  • It's logic prevents compressing darwin arm64 binary as it causes UPX to create broken file
  • Use this script in goreleaser config file as post build hook

Related issue(s)

@mszostok mszostok self-assigned this May 6, 2022
mszostok
mszostok approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mszostok mszostok added bug Something isn't working area/cli Relates to CLI labels May 10, 2022
@mszostok mszostok merged commit 4ca78b1 into capactio:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@tmitchell tmitchell Awaiting requested review from tmitchell tmitchell is a code owner

@pkosiec pkosiec Awaiting requested review from pkosiec pkosiec is a code owner

@mkuziemko mkuziemko Awaiting requested review from mkuziemko mkuziemko is a code owner

Assignees

@mszostok mszostok

Labels
area/cli Relates to CLI bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid darwin arm64 build on the release page
2 participants
@blazejmalecki @mszostok