Refactor manifests to use yaml merger #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszo
force-pushed
the
merger
branch
2 times, most recently
from
1558845
to
67b4fe0
Compare
lukaszo
requested review from
mszostok,
pkosiec,
platten and
Trojan295
as code owners
Trojan295
reviewed
Aug 9, 2021
| @@ -213,3 +213,21 @@ spec: | |||
| image: bitnami/kubectl:1.18 | |||
| command: [sh, -c] | |||
| args: ["kubectl create -f {{inputs.artifacts.manifest.path}} --output=yaml > {{outputs.artifacts.manifest.path}}"] | |||
|
|
|||
| - name: prepare-parameters | |||
There was a problem hiding this comment.
I think this template should be used somewhere in the main workflow. I don't see any other changes to this file.
There was a problem hiding this comment.
Removed, when there are only 2 sources it's less code to fill it in two steps.
Trojan295
approved these changes
Aug 10, 2021
Trojan295
added a commit
to Trojan295/hub-manifests
that referenced
this pull request
Aug 13, 2021
Co-authored-by: Mateusz Szostok <mateusz@structsure.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Testing
valuevs"values"Related issue(s)
capactio/capact#419