Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Input JSON schemas #51

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Improve Input JSON schemas #51

merged 1 commit into from
Jan 24, 2022

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Jan 21, 2022

Description

Changes proposed in this pull request:

  • Improve Input JSON schemas
    • Fix encountered issues
    • Improve rendering of some JSON schemas in Dashboard

Screenshots

Example screenshot:

Screenshot 2022-01-21 at 13 21 27

Testing

  1. Make sure you have the latest Capact CLI (see instruction https://capact.io/docs/next/cli/getting-started#latest---from-the-latest-main-commit)
  2. Run:
# Create local cluster
capact environment create kind --wait 5m
# Install Capact from latest charts
export SOURCE_REPO_URL="github.com/pkosiec/hub-manifests"
export SOURCE_REPO_REF="fix-schemas"
capact install \
            --verbose \
            --helm-repo=@latest \
            --version=@latest \
            --capact-overrides="hub-public.populator.enabled=true,hub-public.populator.manifestsLocation.repository=${SOURCE_REPO_URL},hub-public.populator.manifestsLocation.branch=${SOURCE_REPO_REF}"
  1. Navigate to the https://dashboard.capact.local/ and log in according to the instructions on https://ui-docs.capact-website.pages.dev/docs/next/dashboard-ui/overview/.
  2. Play around with the Hub view to see improved input JSON schemas.

@pkosiec pkosiec added bug Something isn't working enhancement New feature or request area/hub-manifests Relates to Hub manifests labels Jan 21, 2022
@pkosiec pkosiec added this to the 0.6.0 milestone Jan 21, 2022
Copy link
Member

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

out of curiosity, did you use our Helm chart generator for Mattermost? or did you do it manually?

@pkosiec
Copy link
Member Author

pkosiec commented Jan 24, 2022

@mszostok Thanks!
Nope, I didn't use the generator, I edited the schema in place in IDE by using multi-selection and this plugin: https://plugins.jetbrains.com/plugin/7160-camelcase. The current Helm generator would fix the issues with boolean parameters, but I would still need to edit the titles manually, as it generates CamelCase titles. We can think about such future improvement for Helm Generator.

@pkosiec pkosiec merged commit ecc5b78 into capactio:main Jan 24, 2022
@pkosiec pkosiec deleted the fix-schemas branch January 24, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hub-manifests Relates to Hub manifests bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants