Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of context schema #65

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

mkuziemko
Copy link
Contributor

@mkuziemko mkuziemko commented Apr 4, 2022

Description

Changes proposed in this pull request:

  • change contextSchema of storage backends to objects

Related issue(s)

@mkuziemko mkuziemko added the area/hub-manifests Relates to Hub manifests label Apr 4, 2022
@pkosiec pkosiec self-assigned this Apr 5, 2022
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll wait with approve once capactio/capact#694 is ready to go 🙂

"type": "string",
"format": "uri"
},
"contextSchema":{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tenor-242827005

Finally, nice object with schema 👌

Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

@mkuziemko mkuziemko merged commit 9d655f4 into capactio:main Apr 8, 2022
@mkuziemko mkuziemko deleted the fix_context_schema branch April 8, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hub-manifests Relates to Hub manifests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants