Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(performance): add missing methods (e. g. setAttribute(...), getAttribute(...)) #505

Closed
3 of 11 tasks
robingenz opened this issue Dec 6, 2023 · 4 comments · Fixed by #770
Closed
3 of 11 tasks

feat(performance): add missing methods (e. g. setAttribute(...), getAttribute(...)) #505

robingenz opened this issue Dec 6, 2023 · 4 comments · Fixed by #770
Assignees
@ebarooni
Labels
feature Feature package: performance

Comments

@robingenz
Copy link
Member

robingenz commented Dec 6, 2023 •
edited
Loading

Plugin(s)

  • Analytics
  • App
  • App Check
  • Authentication
  • Crashlytics
  • Cloud Firestore
  • Cloud Messaging
  • Performance
  • Remote Config

Current problem

The Firebase Performance Monitoring plugin currently lacks support for the following methods:

Note: Not all methods are available on all platforms.

Preferred solution

Add support for the missing methods for Android, iOS and Web to the plugin.

Alternative options

No response

Additional context

Before submitting
@robingenz robingenz mentioned this issue Dec 6, 2023
Closed
@triyam
Copy link

triyam commented Dec 6, 2023 •
edited
Loading

/attempt #505

@triyam triyam mentioned this issue Dec 6, 2023
Closed
@triyam
Copy link

triyam commented Dec 6, 2023

Let me know when to move ahead

@robingenz
Copy link
Member Author

robingenz commented Dec 7, 2023 •
edited
Loading

@triyam Thank you for your willingness! Unfortunately, I can't assign you the issue as it seems you have little experience in developing Capacitor plugins so far (your changes in definitions.ts does not work for Capacitor). Since I am currently the only maintainer in the Capawesome organization, I don't have the capacity to guide you through the bounty program and conduct intensive reviews. I really hope you understand that!

This was referenced Dec 7, 2023
Closed
Closed
@triyam
Copy link

triyam commented Dec 7, 2023

Its okay I can understand

ebarooni added a commit that referenced this issue Dec 6, 2024
@ebarooni
feat(performance): add missing methods (#505)
67c0f3a 
Add method definitions.
ebarooni added a commit that referenced this issue Dec 6, 2024
@ebarooni
feat(performance): add missing methods (#505)
a3c5cd3 
Implement all method definitions on the web.
ebarooni added a commit that referenced this issue Dec 7, 2024
@ebarooni
feat(performance): add missing methods (#505)
b313185 
Update definitions.
ebarooni added a commit that referenced this issue Dec 7, 2024
@ebarooni
feat(performance): add missing methods (#505)
f5db8be 
Change return of getAttributes on the web.
ebarooni added a commit that referenced this issue Dec 7, 2024
@ebarooni
feat(performance): add missing methods (#505)
284d70b 
Implement all methods on ios.
@ebarooni ebarooni linked a pull request Dec 7, 2024 that will close this issue
feat(performance): add missing methods (e. g. setAttribute(...), getAttribute(...)) #770
Merged
3 tasks
@robingenz robingenz mentioned this issue Dec 8, 2024
Merged
3 tasks
ebarooni added a commit that referenced this issue Dec 8, 2024
@ebarooni
feat(performance): add missing methods (#505)
96856dc 
Add since attribute to definitions.
ebarooni added a commit that referenced this issue Dec 9, 2024
@ebarooni
feat(performance): add missing methods (#505)
1a10f1f 
Implement new methods on android.
ebarooni added a commit that referenced this issue Dec 9, 2024
@ebarooni
feat(performance): add missing methods (#505)
4187829 
Add changeset
ebarooni added a commit that referenced this issue Dec 10, 2024
@ebarooni
feat(performance): add missing methods (#505)
0bd6824 
Remove classes and update types.
ebarooni added a commit that referenced this issue Dec 11, 2024
@ebarooni
feat(performance): add missing methods (#505)
9aa213d 
Refactor helper methods into separate class.
ebarooni added a commit that referenced this issue Dec 11, 2024
@ebarooni
feat(performance): add missing methods (#505)
a83e826 
Remove record implementation from android.
ebarooni added a commit that referenced this issue Dec 11, 2024
@ebarooni
feat(performance): add missing methods (#505)
b6ccc1f 
Remove record implementation from ios.
ebarooni added a commit that referenced this issue Dec 11, 2024
@ebarooni
feat(performance): add missing methods (#505)
04e3298 
Update method definitions.ts for record.
ebarooni added a commit that referenced this issue Dec 12, 2024
@ebarooni
feat(performance): add missing methods (#505)
49724a7 
Remove none return type from methods.
ebarooni added a commit that referenced this issue Dec 12, 2024
@ebarooni
feat(performance): add missing methods (#505)
5f8523b 
Remove throwing error when trace does not exist.
robingenz added a commit that referenced this issue Dec 12, 2024
@ebarooni @robingenz
feat(performance): add missing methods (e. g. setAttribute(...), getA…
1cfcf18 
…ttribute(...)) (#770)

* feat(performance): add missing methods  (#505)

Add method definitions.

* feat(performance): add missing methods  (#505)

Implement all method definitions on the web.

* feat(performance): add missing methods  (#505)

Update definitions.

* feat(performance): add missing methods  (#505)

Change return of getAttributes on the web.

* feat(performance): add missing methods  (#505)

Implement all methods on ios.

* feat(performance): add missing methods  (#505)

Add since attribute to definitions.

* feat(performance): add missing methods  (#505)

Implement new methods on android.

* feat(performance): add missing methods  (#505)

Add changeset

* feat(performance): add missing methods  (#505)

Remove classes and update types.

* wip

* feat(performance): add missing methods  (#505)

Refactor helper methods into separate class.

* feat(performance): add missing methods  (#505)

Remove record implementation from android.

* feat(performance): add missing methods  (#505)

Remove record implementation from ios.

* feat(performance): add missing methods  (#505)

Update method definitions.ts for record.

* feat(performance): add missing methods  (#505)

Remove none return type from methods.

* feat(performance): add missing methods  (#505)

Remove throwing error when trace does not exist.

---------

Co-authored-by: Robin Genz <mail@robingenz.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ebarooni ebarooni

Labels
feature Feature package: performance
Projects
None yet
Milestone
No milestone
3 participants
@robingenz @triyam @ebarooni