feat(performance): add missing methods (e. g. setAttribute(...), getAttribute(...)) #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add method definitions.
Implement all method definitions on the web.
Update definitions.
Change return of getAttributes on the web.
Implement all methods on ios.
11 tasks
@capacitor-firebase/analytics
@capacitor-firebase/app
@capacitor-firebase/app-check
@capacitor-firebase/authentication
@capacitor-firebase/crashlytics
@capacitor-firebase/firestore
@capacitor-firebase/functions
@capacitor-firebase/messaging
@capacitor-firebase/performance
@capacitor-firebase/remote-config
@capacitor-firebase/storage
commit: |
robingenz
requested changes
Dec 8, 2024
packages/performance/ios/Plugin/FirebasePerformancePlugin.swift
Outdated
Show resolved
Hide resolved
Add since attribute to definitions.
Implement new methods on android.
Add changeset
robingenz
requested changes
Dec 10, 2024
packages/performance/ios/Plugin/FirebasePerformancePlugin.swift
Outdated
Show resolved
Hide resolved
.../io/capawesome/capacitorjs/plugins/firebase/performance/classes/results/GetMetricResult.java
Outdated
Show resolved
Hide resolved
packages/performance/ios/Plugin/FirebasePerformancePlugin.swift
Outdated
Show resolved
Hide resolved
Remove classes and update types.
robingenz
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Please test the changes using the https://github.com/robingenz/capacitor-firebase-plugin-demo project. You just need to add your own Firebase configuration files. I will soon create a separate sample project for each plugin for testing, so that this will be easier in the future.
...n/java/io/capawesome/capacitorjs/plugins/firebase/performance/FirebasePerformancePlugin.java
Outdated
Show resolved
Hide resolved
Refactor helper methods into separate class.
Remove record implementation from android.
Remove record implementation from ios.
Update method definitions.ts for record.
robingenz
requested changes
Dec 12, 2024
...n/java/io/capawesome/capacitorjs/plugins/firebase/performance/FirebasePerformancePlugin.java
Outdated
Show resolved
Hide resolved
Remove none return type from methods.
robingenz
requested changes
Dec 12, 2024
Remove throwing error when trace does not exist.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset).Close #505