Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): catch all native errors #149

Merged
merged 2 commits into from
Jul 15, 2022
Merged

fix(android): catch all native errors #149

merged 2 commits into from
Jul 15, 2022

Conversation

robingenz
Copy link
Member

@robingenz robingenz commented Jul 15, 2022 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).

From now on, all native errors will be catched and passed to the webview.

Close #136

@robingenz robingenz added platform: android Android platform bug/fix Something isn't working platform: ios iOS platform labels Jul 15, 2022
@robingenz robingenz self-assigned this Jul 15, 2022
@robingenz robingenz marked this pull request as draft July 15, 2022 15:49
@robingenz robingenz changed the title fix: catch all native errors fix(android): catch all native errors Jul 15, 2022
@robingenz robingenz removed the platform: ios iOS platform label Jul 15, 2022
@robingenz robingenz marked this pull request as ready for review July 15, 2022 18:34
@robingenz robingenz merged commit c8543f6 into main Jul 15, 2022
@robingenz robingenz deleted the feat/catch-all-native-errors branch July 15, 2022 18:35
@github-actions github-actions bot mentioned this pull request Jul 15, 2022
Merged
Paso pushed a commit to ice-cream-club/capacitor-firebase that referenced this pull request Apr 19, 2023
@robingenz @Paso
fix(android): catch all native errors (capawesome-team#149)
cfcc7ba
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@robingenz robingenz

Labels
bug/fix Something isn't working platform: android Android platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Reproducible Native App Crash when calling FirebaseAuthentication.signOut()
1 participant
@robingenz