Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firebase App Check #237

Closed

Conversation

jjgriff93
Copy link

Add Firebase App Check package

This PR resolves #177 and adds App Check as a new package for use with Capacitor 4. This allows users to get App Check tokens from the native layer and use for device verification in their web layer, such as for use with the AngularFire library, Firebase Web SDK and others.

I've done my best to follow the semantics used in the other packages so that it fits with this library but please feel free to suggest/make any changes you feel appropriate.

Have tested with my app running on iOS and Android successfully but probably a good idea for you to test as well!

Any questions let me know, and consider this my thanks for putting together the other great packages in this repo! :)

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).

@jjgriff93 jjgriff93 changed the title Jjgriff93/add appcheck Add Firebase Appcheck Nov 4, 2022
@jjgriff93 jjgriff93 changed the title Add Firebase Appcheck Add Firebase App Check Nov 4, 2022
@jjgriff93 jjgriff93 mentioned this pull request Nov 4, 2022
@robingenz
Copy link
Member

Hi @jjgriff93,
thank you for your contribution.
Unfortunately I can't accept this PR because you just copied the code from another GitHub project (https://github.com/mattmilan-dev/capacitor-firebase-appcheck) and don't even mention the original maintainer anywhere (or did I miss it?).

Apart from that, I prefer to create the boilerplate code of a new plugin myself (see comment) so that the review is not so time-consuming.

@robingenz robingenz closed this Nov 4, 2022
@jjgriff93
Copy link
Author

@robingenz you're right, some code is taken from that repo but quite a lot is changed/updated, either way the maintainer does deserve a mention, my mistake. Feel free to use some of the logic or not in your own boilerplate when you get round to it.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: AppCheck support
2 participants