Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(functions): Add regionOrCustomDomain option to useEmulator. #766

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

dimer47
Copy link
Contributor

@dimer47 dimer47 commented Dec 5, 2024

  • fix useEmulator for specific region

Introduced a new property regionOrCustomDomain to the UseEmulatorOptions interface to enable specifying either a region or a custom domain for callable Firebase functions. This change facilitates greater flexibility in configuring the functions emulator based on deployment preferences. Updated related documentation to reflect these changes for clarity.

Pull request checklist

Please check if your PR fulfills the following requirements:

Close #765

Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments.

packages/functions/src/web.ts Outdated Show resolved Hide resolved
packages/functions/src/definitions.ts Outdated Show resolved Hide resolved
.changeset/cuddly-baboons-add.md Outdated Show resolved Hide resolved
.changeset/cuddly-baboons-add.md Outdated Show resolved Hide resolved
@dimer47
Copy link
Contributor Author

dimer47 commented Dec 6, 2024

Hi @robingenz,

Thank you for review!
I've made the modification and will push it again shortly for those concerned.

Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run npm run fmt to format the code.

@robingenz
Copy link
Member

@dimer47 Let me know if you have any questions!

* fix useEmulator for specific region

Introduced a new property `regionOrCustomDomain` to the `UseEmulatorOptions` interface to enable specifying either a region or a custom domain for callable Firebase functions. This change facilitates greater flexibility in configuring the functions emulator based on deployment preferences. Updated related documentation to reflect these changes for clarity.
@dimer47
Copy link
Contributor Author

dimer47 commented Dec 9, 2024

@robingenz sorry for the delay in getting back, I formatted the code and amended my commit with the fix.

Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@robingenz robingenz changed the title fix(functions): Add regionOrCustomDomain option to useEmulator. feat(functions): Add regionOrCustomDomain option to useEmulator. Dec 9, 2024
@robingenz robingenz merged commit 258ea28 into capawesome-team:main Dec 9, 2024
Copy link

pkg-pr-new bot commented Dec 9, 2024

Open in Stackblitz

@capacitor-firebase/analytics

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/analytics@766

@capacitor-firebase/app

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/app@766

@capacitor-firebase/app-check

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/app-check@766

@capacitor-firebase/authentication

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/authentication@766

@capacitor-firebase/crashlytics

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/crashlytics@766

@capacitor-firebase/firestore

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/firestore@766

@capacitor-firebase/functions

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/functions@766

@capacitor-firebase/messaging

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/messaging@766

@capacitor-firebase/performance

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/performance@766

@capacitor-firebase/remote-config

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/remote-config@766

@capacitor-firebase/storage

npm i https://pkg.pr.new/capawesome-team/capacitor-firebase/@capacitor-firebase/storage@766

commit: 19240cf

@github-actions github-actions bot mentioned this pull request Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Fix on Web and add argument for Region Support to FirebaseFunctions.useEmulator for Web Version
2 participants