Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android-foreground-service): add method for updating foreground service notification #328

Merged
merged 5 commits into from
Nov 19, 2024
Merged

feat(android-foreground-service): add method for updating foreground service notification #328

merged 5 commits into from
Nov 19, 2024

Conversation

xsorifc28
Copy link
Contributor

@xsorifc28 xsorifc28 commented Nov 19, 2024 •
edited
Loading

…service notification

Fixes #327

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).
  • I have read and followed the pull request guidelines.

robingenz
robingenz requested changes Nov 19, 2024
View reviewed changes
Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few small changes

.changeset/olive-melons-joke.md Outdated Show resolved Hide resolved
packages/android-foreground-service/src/definitions.ts Outdated Show resolved Hide resolved
packages/android-foreground-service/src/definitions.ts Outdated Show resolved Hide resolved
packages/android-foreground-service/src/definitions.ts Outdated Show resolved Hide resolved
@xsorifc28 @robingenz
fix: update change log, set version to 6.1.0
85f6d20 
Co-authored-by: Robin Genz <mail@robingenz.dev>
@xsorifc28
Copy link
Contributor Author

LGTM, just a few small changes

Changes applied, PTAL.

robingenz
robingenz approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 19, 2024

Open in Stackblitz

@capawesome-team/capacitor-android-battery-optimization

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-android-battery-optimization@328

@capawesome/capacitor-android-dark-mode-support

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-android-dark-mode-support@328

@capawesome-team/capacitor-android-foreground-service

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-android-foreground-service@328

@capawesome/capacitor-app-review

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-app-review@328

@capawesome/capacitor-app-update

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-app-update@328

@capawesome/capacitor-background-task

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-background-task@328

@capawesome/capacitor-badge

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-badge@328

@capawesome/capacitor-cloudinary

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-cloudinary@328

@capawesome-team/capacitor-datetime-picker

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-datetime-picker@328

@capawesome-team/capacitor-file-opener

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome-team/capacitor-file-opener@328

@capawesome/capacitor-file-picker

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-file-picker@328

@capawesome/capacitor-live-update

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-live-update@328

@capawesome/capacitor-managed-configurations

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-managed-configurations@328

@capawesome/capacitor-photo-editor

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-photo-editor@328

@capawesome/capacitor-posthog

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-posthog@328

@capawesome/capacitor-screen-orientation

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-screen-orientation@328

@capawesome/capacitor-torch

npm i https://pkg.pr.new/capawesome-team/capacitor-plugins/@capawesome/capacitor-torch@328

commit: 85f6d20

@xsorifc28 xsorifc28 changed the title feat(android-foreground-service): add method for updating foreground service notification feat(#327): add method for updating foreground service notification Nov 19, 2024
@xsorifc28 xsorifc28 changed the title feat(#327): add method for updating foreground service notification feat(android-foreground-service): add method for updating foreground service notification Nov 19, 2024
@robingenz robingenz merged commit 6051ba5 into capawesome-team:main Nov 19, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robingenz robingenz robingenz approved these changes

Assignees
No one assigned
Labels
feature Feature request package: android-foreground-service platform: android Android platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: method for updating foreground service notification
2 participants
@xsorifc28 @robingenz