Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run diff -q #{release_path}/db/migrate #{current_path}/db/migrate befo... #71

Merged
merged 3 commits into from
May 26, 2014

Conversation

umhan35
Copy link
Contributor

@umhan35 umhan35 commented Apr 16, 2014

...re running rake db:migrate

So it shorten the unnecessary time to run migrations.

@umhan35
Copy link
Contributor Author

umhan35 commented Apr 18, 2014

ping @kirs @leehambley @seenmyfate

@umhan35
Copy link
Contributor Author

umhan35 commented Apr 24, 2014

ping @leehambley I hope this can be merged so I can stop using my own fork.

@leehambley
Copy link
Member

@kirs maintains this Gem, sure he'll be happy to merge it when he has time.

@kirs
Copy link
Member

kirs commented Apr 30, 2014

Great idea!

What do you think about making this thing optional?

@allaire
Copy link
Contributor

allaire commented May 13, 2014

Yay for this!

@kirs
Copy link
Member

kirs commented May 19, 2014

@umhan35 any updates concerning my comment?

@umhan35
Copy link
Contributor Author

umhan35 commented May 19, 2014

@kirs It sounds good. I have a rough idea and will try it if I have time tomorrow.

My initial idea is to put a set statement (key name is probably conditionally_migrate, the value would be false) here: https://github.com/capistrano/rails/blob/master/lib/capistrano/tasks/migrations.rake#L22

I came back to China. Sorry for this late reply.

@umhan35
Copy link
Contributor Author

umhan35 commented May 22, 2014

@kirs I wrote some code making conditionally-migrate optional. Please check it out.

kirs added a commit that referenced this pull request May 26, 2014
run `diff -q #{release_path}/db/migrate #{current_path}/db/migrate` befo...
@kirs kirs merged commit ff0eb2b into capistrano:master May 26, 2014
@kirs
Copy link
Member

kirs commented May 26, 2014

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants