Allow early overriding of assets_* parameters #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the `load:defaults` task didn't check whether `assets_roles` or `assets_prefix` had already been set, the default settings could only be overridden from `deploy.rb` or `a_stage.rb`, but not from `Capfile`. However, styles differ and keeping the relevant settings close to the appropriate `require` is possible with this change, while it has no downsides afaik.
|
I've come across this issue today as well. I'm using a different config.assets.prefix value and while assets_prefix is set to match, the directory doesn't get added to the linked_dirs setting. |
kirs
added a commit
that referenced
this pull request
May 26, 2014
Allow early overriding of assets_* parameters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
load:defaultstask didn't check whetherassets_rolesorassets_prefixhad already been set, the default settings could only be overridden fromdeploy.rbora_stage.rb, but not fromCapfile. However, styles differ and keeping the relevant settings close to the appropriaterequireis possible with this change, while it has no downsides afaik.