Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand home dir for user rbenv_path to support quoted ENV in SSHKit #56

Closed
wants to merge 1 commit into from

Conversation

cshaffer
Copy link

@cshaffer cshaffer commented Aug 8, 2015

As a result of capistrano/sshkit#250 for user installs of rbenv result in incorrect ENV in the mapped bins.

So what used to be this:
$ RBENV_ROOT=~/.rbenv RBENV_VERSION=2.2.2 ~/.rbenv/bin/rbenv exec gem query --quiet --installed --name-matches ^bundler$

Became this:
RBENV_ROOT="~/.rbenv" RBENV_VERSION="2.2.2" ~/.rbenv/bin/rbenv exec gem query --quiet --installed --name-matches ^bundler$

In other words path expansion was no longer occurring due to the quotes added by SSHKit. This is easy to workaround by overriding the default rbenv_path property, however this PR sets the default to the expanded path so that is no longer necessary.

@cshaffer
Copy link
Author

Whoops looks like deploy_user isn't valid anymore: capistrano/capistrano#1399. Closing until I come up with a better way.

@cshaffer cshaffer closed this Aug 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant