Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mock in test to use proper tf.keras #248

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

JGSweets
Copy link
Contributor

@JGSweets JGSweets commented Jun 1, 2021

Allows TF2.5.0 with fix to test which was incorrectly calling 'keras.... instead of tf.keras....

Reverts the TF version lock from: #220

@JGSweets JGSweets added Bug Something isn't working High Priority Dramatic improvement, inaccurate calculation(s) or bug / feature making the library unusable labels Jun 1, 2021
@@ -308,7 +308,7 @@ def mock_open(filename, *args):
return StringIO('{}')


@mock.patch("keras.models.load_model")
@mock.patch("tensorflow.keras.models.load_model")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix 👍

@grant-eden grant-eden enabled auto-merge (squash) June 1, 2021 16:48
@grant-eden grant-eden merged commit 8e4474b into capitalone:main Jun 1, 2021
stevensecreti pushed a commit to stevensecreti/DataProfiler that referenced this pull request Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working High Priority Dramatic improvement, inaccurate calculation(s) or bug / feature making the library unusable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants