Updating profile example to have unstructured #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grant-eden
requested review from
AnhTruong,
ChrisWallace2020,
JGSweets and
lettergram
as code owners
grant-eden
commented
Jun 1, 2021
| @@ -272,7 +272,7 @@ | |||
| "id": "e2285f19-9b34-4484-beaa-79df890b2825", | |||
| "metadata": {}, | |||
| "source": [ | |||
| "# A deeper dive into `CSVData`\n", | |||
| "## A deeper dive into `CSVData`\n", | |||
There was a problem hiding this comment.
This has needed to be changed for a while. The auto-documentation gets messed up if there are two of the largest headings in the same example.
|
Can you add this to the fixes in here? Should be simple few line changes: #254 |
grant-eden
commented
Jun 7, 2021
| " \"int.is_enabled\": False, \n", | ||
| " \"float.is_enabled\": False, \n", | ||
| " \"order.is_enabled\": False, \n", | ||
| " \"category.is_enabled\": False, \n", | ||
| " \"datetime.is_enabled\": False,})\n", | ||
| "profile_options.set({'data_labeler.data_labeler_object': data_labeler})\n", | ||
| "profile_options.set({'structured_options.data_labeler.data_labeler_object': data_labeler})\n", |
grant-eden
commented
Jun 7, 2021
| @@ -405,7 +405,7 @@ | |||
| "outputs": [], | |||
| "source": [ | |||
| "# predict with the labeler loaded from path\n", | |||
| "profile_options.set({'data_labeler.data_labeler_dirpath': 'data_labeler_saved'})\n", | |||
| "profile_options.set({'structured_options.data_labeler.data_labeler_dirpath': 'data_labeler_saved'})\n", | |||
JGSweets
approved these changes
Jun 7, 2021
ChrisWallace2020
approved these changes
Jun 8, 2021
stevensecreti
pushed a commit
to stevensecreti/DataProfiler
that referenced
this pull request
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know what you think